Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra_headers option to http method call #5753

Merged
merged 2 commits into from
Feb 17, 2020
Merged

Add extra_headers option to http method call #5753

merged 2 commits into from
Feb 17, 2020

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Feb 14, 2020 •
edited
Loading

What does this PR do?

Append extra_headers option to http method call

Needed here: https://github.com/DataDog/integrations-core/pull/5729/files#diff-b778b4343871a44d5bbaa529942c581dR110-R115

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@AlexandreYang AlexandreYang marked this pull request as ready for review February 14, 2020 18:35
@AlexandreYang AlexandreYang requested review from a team as code owners February 14, 2020 18:35
ofek
ofek requested changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way you'll have no way of overriding. Please call it extra_headers and strip it out like persist,

@AlexandreYang AlexandreYang changed the title Append http headers instead of overriding Append extra_headers option to http method call Feb 14, 2020
@AlexandreYang
Copy link
Member Author

This way you'll have no way of overriding. Please call it extra_headers and strip it out like persist,

@ofek Yes, that's a good point. I reimplemented it as extra_headers.

AlexandreYang
AlexandreYang commented Feb 14, 2020
View reviewed changes
Copy link
Member Author

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

ofek
ofek requested changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

datadog_checks_base/datadog_checks/base/utils/http.py Show resolved Hide resolved
ofek
ofek previously approved these changes Feb 14, 2020
View reviewed changes
@AlexandreYang AlexandreYang merged commit ac9daf6 into master Feb 17, 2020
@AlexandreYang AlexandreYang deleted the alex/http_headers branch February 17, 2020 09:12
@AlexandreYang AlexandreYang changed the title Append extra_headers option to http method call Add extra_headers option to http method call Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@FlorianVeaux FlorianVeaux Awaiting requested review from FlorianVeaux

Assignees
No one assigned
Labels
integration/datadog_checks_base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandreYang @ofek @FlorianVeaux