-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra_headers option to http method call #5753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way you'll have no way of overriding. Please call it extra_headers
and strip it out like persist
,
16ebd8d
to
7e441e5
Compare
@ofek Yes, that's a good point. I reimplemented it as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What does this PR do?
Append extra_headers option to http method call
Needed here: https://github.com/DataDog/integrations-core/pull/5729/files#diff-b778b4343871a44d5bbaa529942c581dR110-R115
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached